cipher: allow getting the proto of a ciphersuite #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
commented
Sep 10, 2024
ctz
approved these changes
Sep 10, 2024
ctz
reviewed
Sep 10, 2024
cpu
force-pushed
the
cpu-cipher-proto-version
branch
from
122b69b
to
8c0e3bc
Compare
This commit adds a `rustls_supported_ciphersuite_protocol_version()` fn for getting the `rustls_tls_version` IANA registered protocol version identifier supported by a given `rustls_supported_ciphersuite`. This avoids downstream users having to use `rustls_supported_ciphersuite_get_name()` and then matching on the protocol version prefix in that identifier.
cpu
force-pushed
the
cpu-cipher-proto-version
branch
from
8c0e3bc
to
bfa0029
Compare
ctz
approved these changes
Sep 10, 2024
|
Feels small enough to land without additional reviews. Happy to revisit if there's further feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
rustls_supported_ciphersuite_protocol_version()fn for getting the IANA registered protocol version identifier supported by a givenrustls_supported_ciphersuite. This avoids downstream users having to userustls_supported_ciphersuite_get_name()and then matching on the protocol version prefix in that identifier (e.g. curl/curl#14840). This is equivalent to the upstreamSupportedCipherSuite.version()fn, but tailored to FFI users.